Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial support for zerodev #578

Merged
merged 7 commits into from
Oct 19, 2023
Merged

feat: initial support for zerodev #578

merged 7 commits into from
Oct 19, 2023

Conversation

r-marques
Copy link
Member

@r-marques r-marques commented Sep 20, 2023

Description

Make sure you are using node 18

nvm install 18
nvm use 18
  • Testing:
export PROJECT_ID=******
export INFURA_TOKEN=*****
export NETWORK_NAME=one-staging

yarn integration integration/external/Zerodev.test.ts

To get a PROJECT_ID check create a project and set up gas policies

  • Add initial support for zeroDev. TxParameters now has an extra optional config called zeroDevSigner that when set will be use to make contract calls:
 zerodevProvider = await ZeroDevEthersProvider.init('ECDSA', {
    projectId,
    owner: convertEthersV6SignerToAccountSigner(account as any),
  })

  const signer = zerodevProvider.getAccountSigner()
  const publisher = await Account.fromZeroDevSigner(signer)
  const ddo = await nevermined.assets.create(assetAttributes, publisher, undefined, { zeroDevSigner: signer })
  })

Is this PR related with an open issue?

Closes #567

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

Funny gif

Put a link of a funny gif inside the parenthesis-->

Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good so far

integration/external/Zerodev.test.ts Outdated Show resolved Hide resolved
src/keeper/contracts/ContractBase.ts Outdated Show resolved Hide resolved
src/keeper/contracts/ContractBase.ts Outdated Show resolved Hide resolved
@r-marques r-marques marked this pull request as ready for review October 18, 2023 17:19
@r-marques r-marques requested review from a team as code owners October 18, 2023 17:19
Copy link
Member

@aaitor aaitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aaitor
Copy link
Member

aaitor commented Oct 19, 2023

there is an IT compilation problem: https://github.com/nevermined-io/sdk-js/actions/runs/6564355069/job/17830554815?pr=578#step:9:16
But beyond that, the implementation looks good to me

@r-marques r-marques merged commit bb26f8a into develop Oct 19, 2023
3 checks passed
@r-marques r-marques deleted the feat/zerodev branch October 19, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants